From 00bbb0e6b3992ee79a3cf6d15dae2e51e0a04414 Mon Sep 17 00:00:00 2001
From: ericek111 <erik@brocko.eu>
Date: Thu, 10 Sep 2026 17:22:54 +0000
Subject: [PATCH] Mark the picked line in the log only while the window is in
 front
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

A marked line in a window behind says nothing about where the keyboard
is. The log takes the marks off as another window is activated and puts
them back when it comes forward; the contacts stay picked in between, so
"Change Operator…" and Delete still act on what the operator picked.

The frame around the cell the keyboard is on goes with them. The theme
draws that frame with a rectangle inside the cell, not with the cell's
own border, so it takes a style on the template.

Quick edit moves the picked line: Ctrl+Q and Ctrl+A step through the log
from the entry window, and the contact in the entry boxes is the picked
line here and is scrolled to.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0157i7PiZyqBkquxS9A6FTdQ
---
 src/Nonemm.App/Windows/LogWindow.axaml    |  7 ++
 src/Nonemm.App/Windows/LogWindow.axaml.cs | 84 +++++++++++++++++++++++
 2 files changed, 91 insertions(+)

diff --git a/src/Nonemm.App/Windows/LogWindow.axaml b/src/Nonemm.App/Windows/LogWindow.axaml
index 2a07798..99932f3 100644
--- a/src/Nonemm.App/Windows/LogWindow.axaml
+++ b/src/Nonemm.App/Windows/LogWindow.axaml
@@ -29,6 +29,13 @@
         <Style Selector="DataGridColumnHeader">
           <Setter Property="MinHeight" Value="0" />
         </Style>
+        <!-- the frame around the cell the keyboard is on goes with the picked
+             lines while another window is in front. The theme draws it with a
+             rectangle inside the cell rather than with the cell's own border,
+             so setting the border brush does nothing -->
+        <Style Selector="DataGrid.away DataGridCell:current /template/ Rectangle">
+          <Setter Property="IsVisible" Value="False" />
+        </Style>
         <!-- the editing box takes the same height as the text it covers,
              otherwise it grows the row and the whole grid shifts as editing
              starts. Its border is what would make it two pixels taller, so it
diff --git a/src/Nonemm.App/Windows/LogWindow.axaml.cs b/src/Nonemm.App/Windows/LogWindow.axaml.cs
index 91682c0..bf2db4e 100644
--- a/src/Nonemm.App/Windows/LogWindow.axaml.cs
+++ b/src/Nonemm.App/Windows/LogWindow.axaml.cs
@@ -24,6 +24,16 @@ public sealed partial class LogWindow : RefreshableWindow
     /// when only the values changed, so that an edit does not rebuild the list
     /// and move the view.
     private List<LogRow> shownRows = [];
+    /// The contacts the operator picked, by id. The grid is told to show them
+    /// as picked only while this window is in front: a marked line in a window
+    /// behind says nothing about where the keyboard is.
+    private List<string> picked = [];
+    /// True while this window is setting the selection itself, so that its own
+    /// changes are not read back as the operator's.
+    private bool picking;
+    /// The contact quick edit is on, so that the picked line follows Ctrl+Q
+    /// and Ctrl+A rather than being put back on every refresh.
+    private string quickEditId = "";
     private string finding = "";
 
     public LogWindow(AppSession session)
@@ -39,11 +49,79 @@ public sealed partial class LogWindow : RefreshableWindow
         Rows.PreparingCellForEdit += SelectCellText;
         Rows.CellEditEnding += TakeCellEdit;
         Rows.AddHandler(ContextRequestedEvent, OnContextRequested, RoutingStrategies.Bubble);
+        Rows.SelectionChanged += RememberPicked;
+        Activated += (_, _) =>
+        {
+            Rows.Classes.Remove("away");
+            ShowPicked();
+        };
+        Deactivated += (_, _) =>
+        {
+            Rows.Classes.Add("away");
+            HidePicked();
+        };
         Colour(Rows);
         Colour(Earlier);
         Refresh();
     }
 
+    /// What the operator picked. The grid raises this for the picks this window
+    /// makes as well, and those are already known.
+    private void RememberPicked(object? sender, SelectionChangedEventArgs e)
+    {
+        if (picking)
+        {
+            return;
+        }
+        picked = [.. Rows.SelectedItems.OfType<LogRow>().Select(r => r.Qso.Id)];
+    }
+
+    /// Marks the picked lines again. Only a window in front marks them, so the
+    /// callers that are not the window coming to the front ask whether it is in
+    /// front first.
+    private void ShowPicked()
+    {
+        picking = true;
+        Rows.SelectedItems.Clear();
+        foreach (LogRow row in shownRows.Where(r => picked.Contains(r.Qso.Id)))
+        {
+            Rows.SelectedItems.Add(row);
+        }
+        picking = false;
+    }
+
+    /// Takes the marks off while another window has the keyboard. The contacts
+    /// stay picked and are marked again when the window comes back.
+    private void HidePicked()
+    {
+        picking = true;
+        Rows.SelectedItems.Clear();
+        picking = false;
+    }
+
+    /// Quick edit steps through the log from the entry window with Ctrl+Q and
+    /// Ctrl+A. The contact in the entry boxes is the picked line here, and it
+    /// is scrolled to whether or not this window is in front.
+    private void FollowQuickEdit()
+    {
+        string id = session.Position?.Editing?.Id ?? "";
+        if (id == quickEditId || id.Length == 0)
+        {
+            quickEditId = id;
+            return;
+        }
+        quickEditId = id;
+        picked = [id];
+        if (IsActive)
+        {
+            ShowPicked();
+        }
+        if (shownRows.FirstOrDefault(r => r.Qso.Id == id) is { } row)
+        {
+            Rows.ScrollIntoView(row, null);
+        }
+    }
+
     /// A cell that has just opened for editing has all of its text selected, so
     /// typing replaces the value rather than adding to it.
     private static void SelectCellText(object? sender, DataGridPreparingCellForEditEventArgs e)
@@ -139,7 +217,13 @@ public sealed partial class LogWindow : RefreshableWindow
             {
                 ShowAgain(bottom, shownRows);
             }
+            // the new list comes with nothing picked
+            if (IsActive)
+            {
+                ShowPicked();
+            }
         }
+        FollowQuickEdit();
         ShowEarlier();
         SummaryText.Text = message.Length > 0 ? message : Summary(session.Logging);
         message = "";