Let the walk and the completeness check read one rule
A box the walk between the entry boxes steps over cannot be typed in, so it must not hold the contact back either. `EntryFields.IsComplete` counted every box marked required, while `MoveFocus` stepped over the ones the contest does not ask this station for, so a contest with a box for some stations only could lock the operator out of his own log. The seven contests the scoring audit named do not do that any more — `bae40bb` gave each of them the boxes N1MM shows, and fifteen reproductions across all seven and both station types log cleanly — but the rule they broke was still there to break again. Completeness now takes the same applicability rule the cursor uses, and `OperatingPosition` answers it in one place for the entry window, the ESM window and logging alike. The audit is marked up for the three findings that are already fixed and for item 14, which turns out to be what N1MM does rather than a fault. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0157i7PiZyqBkquxS9A6FTdQ
This commit is contained in:
@@ -32,7 +32,7 @@ public sealed partial class EntryWindow
|
||||
IsRunning = Logging.IsRunning,
|
||||
HasCall = Logging.Entry.Call.Trim().Length > 0,
|
||||
IsDupe = Logging.Verdict()?.IsDupe == true,
|
||||
HasExchange = Logging.Entry.IsComplete,
|
||||
HasExchange = Logging.IsEntryComplete,
|
||||
CallSent = callSent,
|
||||
ExchangeSent = exchangeSent,
|
||||
SendsCallOnce = session.Settings.EsmSendsCallOnce,
|
||||
|
||||
@@ -484,7 +484,7 @@ public sealed partial class EntryWindow : Window
|
||||
_ = RunEsmAsync();
|
||||
return;
|
||||
}
|
||||
if (!Logging.Entry.IsComplete)
|
||||
if (!Logging.IsEntryComplete)
|
||||
{
|
||||
MoveFocus(forward: true);
|
||||
return;
|
||||
@@ -1136,7 +1136,7 @@ public sealed partial class EntryWindow : Window
|
||||
// the next message of the contact instead of logging it, and Ctrl+Z
|
||||
// means log it and open the window. N1MM calls `LogContact` at the
|
||||
// same point
|
||||
if (Logging.Entry.Call.Trim().Length > 0 && Logging.Entry.IsComplete)
|
||||
if (Logging.Entry.Call.Trim().Length > 0 && Logging.IsEntryComplete)
|
||||
{
|
||||
LogContact();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user