myTeamSpeak docs: the synced config item, sync edge cases and limits
CONFIG_SYNC.md lists the class 5 config item's fields; none maps onto a setting of ours, so sync leaves it alone. IMPLEMENTATION.md covers the session lock, duplicate keys in the account, bookmarks following an identity's conflict, interrupted runs, and what sync cannot catch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -16,7 +16,8 @@ that Android 13 lacks (hence `HttpURLConnection`, not `java.net.http`).
|
||||
was changed elsewhere) `fetch` signs out. All requests share one session (`MyTeamSpeakLogin.request`),
|
||||
as the official client's do: signed in on first use, again when the service reports it expired
|
||||
(102/109), ended on sign-out or exit. Signing in for every request gets the account's logins throttled
|
||||
within a few dozen (seen 2026-10-15: `login` timed out for minutes).
|
||||
within a few dozen (seen 2026-10-15: `login` timed out for minutes). A sign-in runs under its own lock,
|
||||
not the login's, so `isSignedIn`/`email`/`username` answer at once on the UI thread while one is under way.
|
||||
- `MyTeamSpeak.download(Credentials)` — signs in (`authentication/login`), unwraps the item key, pulls
|
||||
BOOKMARK, IDENTITY and ITEM_FOLDER with one `synchronization/requestServerItems` against an empty
|
||||
local state (all-zero global and class versions, no details), decrypts every item, then ends the
|
||||
@@ -36,7 +37,8 @@ Observed on the live account: a bookmark may name its identity by the identity's
|
||||
of its item UUID; the importer resolves both.
|
||||
|
||||
Tests: `MyTsCryptoTest` (captured vectors), `MyTeamSpeakTest` (download against a replayed server built from
|
||||
the captured login and item), `MyTeamSpeakLoginTest` (persistence, failed sign-in, rejected credentials).
|
||||
the captured login and item), `MyTeamSpeakLoginTest` (persistence, failed sign-in, rejected credentials, a slow
|
||||
sign-in), `MyTeamSpeakSyncTest` (two-way sync between installations against a fake account).
|
||||
|
||||
## Two-way sync
|
||||
|
||||
@@ -54,7 +56,25 @@ identity is each installation's own: `is_default` is not compared, an identity n
|
||||
uploaded as its default only when it has none, and one brought here becomes ours only when we have none
|
||||
(otherwise installations flip each other's default on every run). Edits are
|
||||
written over the item's current `Item_Data` field by field (`ProtobufMessage`), so fields this client does not
|
||||
model survive.
|
||||
model survive. The synced settings item (class 5) is listed in `CONFIG_SYNC.md`; none of it maps onto ours.
|
||||
|
||||
Cases the plain three-way rule gets wrong:
|
||||
|
||||
- The local store holds one identity per key, the account may hold several (the official client can import
|
||||
the same key twice). Only the first account item for a key is synchronised; the others are kept as the
|
||||
account has them, never merged into ours (which would write one over the other on the next run). A bookmark
|
||||
using such a copy connects with the local identity of that key.
|
||||
- Deleting an identity here clears it from our bookmarks. When the identity was meanwhile changed in the
|
||||
account (a conflict), a bookmark whose only change is that cleared link does not go out on its own: it
|
||||
follows the identity's conflict — relinked to the restored identity on "Keep myTeamSpeak's", sent without
|
||||
it on "Delete".
|
||||
- A run cut off between `upload` and `apply` (process killed, screen left) needs nothing special: the next
|
||||
run sees its own uploads as the same on both sides and keeps them.
|
||||
|
||||
Known limits: `push` checks the cursors, then stores; another client storing in between is not seen until the
|
||||
class changes again, as we keep our own class revision as the cursor. The service gives no way to close that
|
||||
gap. Deletions from elsewhere are carried out like any other change, and deleting an identity deletes its key
|
||||
file.
|
||||
|
||||
### How the service and the official client behave (live, 2026-10-15)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user