ericek111/ts3java
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 1 Wiki Activity

Wait for the capture loop when the microphone stops

Browse Source 
stop() closed the encoder and cleared the transmit state while the
capture loop could still be in its last frame, which could turn the
transmit indicator back on, or overlap the loop of a quick restart on
the same speech detector and processing chain. It now closes the line
to wake the loop and waits for it to finish before tearing down.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
ericek111
2026-09-25 10:49:09 +00:00
parent 12ca585d90
commit 8e9c461424
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
ts3-client/core/src/main/java/com/ts3client/audio/CaptureVoiceInput.java
View File

@@ -46,6 +46,8 @@ public final class CaptureVoiceInput implements VoiceInput {
Math.max(1, HANGOVER_MS * VoiceFormat.SAMPLE_RATE / 1000 / VoiceFormat.FRAME_SIZE);
private static final int PREROLL_FRAMES =
Math.max(1, PREROLL_MS * VoiceFormat.SAMPLE_RATE / 1000 / VoiceFormat.FRAME_SIZE);
/** How long stop() waits for the capture loop to finish its frame. */
private static final long STOP_TIMEOUT_MS = 500;
private final ConcurrentLinkedQueue<byte[]> queue = new ConcurrentLinkedQueue<>();
private final AtomicBoolean muted = new AtomicBoolean(false);
@@ -281,9 +283,20 @@ public final class CaptureVoiceInput implements VoiceInput {
public synchronized void stop() {
running.set(false);
if (captureThread != null) {
captureThread.interrupt();
Thread capture = captureThread;
captureThread = null;
if (line != null) {
line.close(); // wakes the capture loop's blocking read
line = null;
}
if (capture != null) {
// Let the loop finish its frame, so it cannot reopen the gate or overlap a restart.
capture.interrupt();
try {
capture.join(STOP_TIMEOUT_MS);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
}
cleanup();
queue.clear();