Offer the server groups we have the power for, not only those needing none
canToggleGroup compared a group's needed member add/remove power with our own i_group_needed_member_*_power, which the server never reports for us: our power is i_group_member_add_power and i_group_member_remove_power. An admin was only ever offered groups that need no power at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -26,8 +26,8 @@ class ServerModelRulesTest {
|
||||
|
||||
@Test
|
||||
void groupNeedsEnoughAddPowerAndRemovePowerToTakeAway() {
|
||||
grant("i_group_needed_member_add_power", 50);
|
||||
grant("i_group_needed_member_remove_power", 20);
|
||||
grant("i_group_member_add_power", 50);
|
||||
grant("i_group_member_remove_power", 20);
|
||||
|
||||
assertTrue(model.canToggleGroup(group(50, 0), false));
|
||||
assertFalse(model.canToggleGroup(group(51, 0), false));
|
||||
@@ -37,8 +37,8 @@ class ServerModelRulesTest {
|
||||
|
||||
@Test
|
||||
void unlimitedPowerIsMinusOneOnEitherSide() {
|
||||
grant("i_group_needed_member_add_power", 75);
|
||||
grant("i_group_needed_member_remove_power", -1);
|
||||
grant("i_group_member_add_power", 75);
|
||||
grant("i_group_member_remove_power", -1);
|
||||
|
||||
assertFalse(model.canToggleGroup(group(-1, 0), false), "a group needing unlimited power");
|
||||
assertTrue(model.canToggleGroup(group(75, 1000), true), "unlimited remove power");
|
||||
|
||||
Reference in New Issue
Block a user