Audit: note that an upload counts as done before the server has it

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-14 20:17:56 +00:00
co-authored by Claude Opus 5.5
parent d61e96a07f
commit e9110c2767
+16
View File
@@ -72,6 +72,22 @@ chat logs, and wrote its profile owner-only.
- **Not tested:** `TeamspeakConnection`'s lifecycle against a fake socket (the smoke test
above covers connect only); the idle release and dead-line replacement in
`PerSpeakerPlayout`; the jitter buffer with real voice from another client.
- **Open (found 2026-10-14): an upload counts as completed before the server has the file.**
`FileTransferManager.runUpload` marks the transfer completed once the last bytes are flushed
to the file socket; the server may still be receiving them. A listing taken right then shows
a partial size (seen on the local 3.13.7 server: 241,664 of 300,000 bytes; a moment later
the full size, and a download got every byte). The file browser's refresh after an upload
can hit this. Fix: before `markCompleted`, wait for the server to confirm, either
- the `notifystatusfiletransfer` for the transfer's `clientftfid` with the "transfer
complete" status (believed to be 2065, not yet seen here); `handleFileTransferEvent`
already parses it but only routes it to `pendingInits` during negotiation, so keep a
waiter registered until the upload ends; or
- the file server closing the connection: `shutdownOutput()`, then read to EOF;
whichever the server is shown to do first (watch what it sends after an upload). Bound the
wait (a few seconds), then mark completed anyway, so a server that never confirms does not
leave uploads stuck at 100 %. About 15–30 lines in core; both frontends follow. A check
that lists the file from a second client right after the upload completes reproduces it.
- **`git stash@{0}`** ("jitter buffer test") is now fully ported, except FEC decoding (TS3
does not use FEC either). It can be dropped.